Conversation
…-on-data-and-add-references-and-units
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #857 +/- ##
===========================================
- Coverage 94.79% 94.79% -0.01%
===========================================
Files 75 75
Lines 5592 5590 -2
===========================================
- Hits 5301 5299 -2
Misses 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-on-data-and-add-references-and-units
…-on-data-and-add-references-and-units
…dd-references-and-units' of https://github.com/ImperialCollegeLondon/virtual_rainforest into 855-hydrology-set-initial-constants-based-on-data-and-add-references-and-units
vgro
commented
May 22, 2025
…-on-data-and-add-references-and-units
updated reference
…-on-data-and-add-references-and-units
…-on-data-and-add-references-and-units
vgro
deleted the
855-hydrology-set-initial-constants-based-on-data-and-add-references-and-units
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the default values for hydrology based on literature research. @lelavathy could you please check I copied everything correctly and double-check the value for
air_entry_potential_inversein you data collection; the value you suggest causes the model to crash (which might not be due to the value, I just want to be sure).here is the documentation: https://virtual-ecosystem.readthedocs.io/en/855-hydrology-set-initial-constants-based-on-data-and-add-references-and-units/api/models/hydrology/constants.html
Fixes #855
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks